gh-115999: Move specializer test from test_dis to test_opcache#126498
Merged
corona10 merged 3 commits intopython:mainfrom Nov 6, 2024
Merged
gh-115999: Move specializer test from test_dis to test_opcache#126498corona10 merged 3 commits intopython:mainfrom
corona10 merged 3 commits intopython:mainfrom
Conversation
corona10
changed the title
corona10
changed the title
Member
Author
|
Motivation: #126450 (comment) |
corona10
commented
Nov 6, 2024
| self.assertFalse(3 in b) | ||
|
|
||
| f() | ||
| self.assert_specialized(f, "CONTAINS_OP_DICT") |
Member
Author
There was a problem hiding this comment.
In the future, if the opcodes become more complex, we may need to count how many specific opcodes have occurred.
markshannon
approved these changes
Nov 6, 2024
Member
markshannon
left a comment
markshannon
left a comment
There was a problem hiding this comment.
Thanks.
We have a lot of tests in test_dis that need to be moved elsewhere. Every test moved helps.
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Dec 8, 2024
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--disable-gilbuilds #115999